Added recovery for broken runs and disabled the start run button if t…

…here are no tasks or are no teams
dres-dev · May 24, 2024 · 12286bd · 12286bd
1 parent cded493
commit 12286bd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/backend/src/main/kotlin/dev/dres/run/RunExecutor.kt b/backend/src/main/kotlin/dev/dres/run/RunExecutor.kt
@@ -59,9 +59,19 @@ object RunExecutor {
             DbEvaluation.filter { (it.ended eq null) }.asSequence().forEach { evaluation ->
                 try {
                     this.schedule(evaluation.toRunManager(store))  /* Re-schedule evaluations. */
-                } catch (e: IllegalStateException) {
-                    logger.error("Could not re-schedule previous run: ${e.message}")
-                    evaluation.ended = System.currentTimeMillis()
+                } catch (e: RuntimeException) {
+                    when (e) {
+                        is IllegalStateException,
+                        is IllegalArgumentException -> {
+                            logger.error("Could not re-schedule previous run: ${e.message}")
+                            evaluation.ended = System.currentTimeMillis()
+                        }
+
+                        else -> {
+                            logger.error("Fatal error during re-scheduling of previous run (${evaluation.evaluationId}): ${e.message}")
+                            throw e
+                        }
+                    }
                 }
             }
         }

diff --git a/frontend/src/app/template/template-list/template-list.component.html b/frontend/src/app/template/template-list/template-list.component.html
@@ -30,6 +30,7 @@ <h1>Evaluation Templates</h1>
         <mat-spinner *ngIf="waitingForRun[row.id]" [diameter]="20"></mat-spinner>
         <span *ngIf="!waitingForRun[row.id]">
           <button
+                  [disabled]="row.taskCount == 0 || row.teamCount == 0"
                   mat-icon-button
                   aria-label="Start new evaluation run from template."
                   matTooltip="Start new evaluation run from template."