#467 Implemented new kis task scoring for perpetual tasks

dres-dev · Jul 17, 2024 · 935ffe0 · 935ffe0
1 parent 2e09cfa
commit 935ffe0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/backend/src/main/kotlin/dev/dres/data/model/run/NonInteractiveEvaluation.kt b/backend/src/main/kotlin/dev/dres/data/model/run/NonInteractiveEvaluation.kt
@@ -73,6 +73,7 @@ class NonInteractiveEvaluation(store: TransientEntityStore, evaluation: DbEvalua
                 DbScoreOption.KIS -> throw IllegalStateException("KIS task scorer is not applicable to non-interactive evaluations")
                 DbScoreOption.AVS -> AvsTaskScorer(this, store)
                 DbScoreOption.LEGACY_AVS -> LegacyAvsTaskScorer(this, store)
+                DbScoreOption.NOOP -> NoOpTaskScorer(this)
                 else -> throw IllegalStateException("The task score option $scoreOption is currently not supported.")
             }
         ) }

diff --git a/backend/src/main/kotlin/dev/dres/run/score/scorer/KisTaskScorer.kt b/backend/src/main/kotlin/dev/dres/run/score/scorer/KisTaskScorer.kt
@@ -16,10 +16,6 @@ class KisTaskScorer(
     store: TransientEntityStore?
 ) : AbstractTaskScorer(scoreable, store) {
 
-    init {
-        require(scoreable.duration != null){"Cannot create a KisTaskScorer for perpetual task '${scoreable.taskId}'"}
-    }
-
     constructor(run: TaskRun, parameters: Map<String, String>, store: TransientEntityStore?) : this(
         run,
         parameters.getOrDefault("maxPointsPerTask", "$defaultmaxPointsPerTask").toDoubleOrNull() ?: defaultmaxPointsPerTask,