Make the restart work correctly. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the restart is active, it can be triggered via the (replace-invalid) function. For this to work, the parser that throws the error cannot be being run directly, but must be called by another parser. When the restart is triggered, it unwinds the parser stack one parser higher than the parser that signaled the condition and then fixes its input and reruns it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the restart is active, it can be triggered via the (replace-invalid) function. For this to work, the parser that throws the error cannot be being run directly, but must be called by another parser. When the restart is triggered, it unwinds the parser stack one parser higher than the parser that signaled the condition and then fixes its input and reruns it.
This fixes a couple errors in the last pull request. However, there's a slight difficulty with the current pull-request: when #'run is called on a parser that raises an exception, invoking the restart will often lead to a loop because, once the replacement is made, it is fed back into the parser and tested again: if all a parser does is raise an exception, this will cause an infinite loop.