Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now ensures all opened streams are closed #662

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nickcodefresh
Copy link

No description provided.

@drewnoakes
Copy link
Owner

Lots of changes here. Can you explain why you made these changes?

@StefanOltmann
Copy link
Contributor

@drewnoakes, I think I understand what happened here.

@nickcodefresh mixed several things in one PR that should be multiple.

Judging from the title of the PR he wanted to change the use of try-with-resources which ensures proper resource closing. There are some places in the code where resources don’t get closed which may lead to memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants