Skip to content

Commit

Permalink
chore: update naming to avoid overlapping
Browse files Browse the repository at this point in the history
  • Loading branch information
jiajic committed Oct 4, 2024
1 parent 3d4ea18 commit 1216dd2
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 14 deletions.
2 changes: 1 addition & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export(spatPlot)
export(spatPlot2D)
export(spatPlot3D)
export(subsetSankeySet)
export(theme_dark)
export(theme_dark2)
export(violinPlot)
exportClasses(giottoSankeyPlan)
exportMethods("+")
Expand Down
8 changes: 4 additions & 4 deletions R/gg_settings.R
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@
}


#' @name theme_dark
#' @title Dark plotting theme
#' @name ggplot_themes
#' @title ggplot2 plotting themes
#' @description
#' A default dark theme. It can be applied through the `theme_param`
#' ggplot2 themes. It can be applied through the `theme_param` arg.
#' @export
theme_dark <- theme(
theme_dark2 <- theme(
plot.background = element_rect(fill = "black"),
panel.background = element_rect(fill = "black"),
panel.grid.major = element_blank(),
Expand Down
7 changes: 4 additions & 3 deletions R/plot_dotplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
#' cluster_column = "leiden_clus",
#' feats = feats,
#' dot_size = mean,
#' dot_color = var
#' dot_color = var,
#' dot_color_gradient = c("#EEEEFF", "#333377")
#' )
#' @export
dotPlot <- function(
Expand Down Expand Up @@ -301,8 +302,8 @@ dotPlot <- function(
axis_title = axis_title,
axis_text = axis_text,
background_color = background_color,
axis.ticks = element_blank(),
axis_text_y_angle = 0
axis_text_y_angle = 0,
axis.ticks = element_blank()
)
pl <- pl + do.call(.gg_theme, args = gg_theme_args)

Expand Down
3 changes: 2 additions & 1 deletion man/dotPlot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions man/theme_dark.Rd → man/ggplot_themes.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1216dd2

Please sign in to comment.