Deprecate read10xVisium() #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated my email address too. Thanks for adding ORCID IDs and NEWS updates also. I haven't usually been updating NEWS to mention Bioc releases if there are no other updates, but happy to start adding that in the future. |
|
I don't either, just meant it there are 0 changes in a release cycle, it might be worth adding a single entry just to we don't have 3 version-long gaps; but also don't have a strong opinion -- still need someone to accept before I can merge though :) |
lmweber
approved these changes
Jun 23, 2024
drighelli
reviewed
Jun 23, 2024
drighelli
reviewed
Jun 23, 2024
drighelli
reviewed
Jun 23, 2024
drighelli
reviewed
Jun 23, 2024
drighelli
reviewed
Jun 23, 2024
drighelli
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example(read10xVisium)throughout function docs & unit tests; this has been changed toexample(SpatialExperiment), which now includes an example usingVisiumIOto read in the example data ininst/extdata.NEWSentires; we have been behind versions 1.11 through 1.15 - it would be great if we can keep things more up to date in the future, even if it's just to add an entry saying "Bioc release 3.nm" prior to the next release when there haven't been any changes in the meantime.DESCRIPTION(could not find @Nick-Eagles; happy to add if you have one?)