-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Maria DB (core API implementation) #1692
base: beta
Are you sure you want to change the base?
Conversation
By removing |
Due to issues I've discussed with the Drizzle team, this PR will only aim to provide MariaDB support with the core API, which means that RQB will come later and will likely be addressed in a separate PR. |
@L-Mario564 Updates? |
@Creative-Difficulty Haven't heard anything from the Drizzle Team. They knew about this PR when I was done adding commits to it in December, but right now I don't know what's the status for adding MariaDB support. |
1 similar comment
This issue has 8 +1's and 14 hearts. The code has been written and @drizzle-team/@dankochetov |
I can bring the Drizzle Team's attention to this PR, although keep in mind there's a lot of other stuff being worked on, including a new dialect (MSSQL), so I can't promise how soon this will be reviewed/merged. |
maybe they should consider mariadb connector instead of mysql2, which is simply faster. |
Can we get some attention for this issue again? Me personally, I prefer postgres over everything, but one company expects our team to use mariadb as the database, but the normal |
Could you @AndriiSherman perhaps give some initial feedback so the submitter @L-Mario564 can iterate and finalize this for merging? |
Any reason this hasn't gone through yet? |
Just to give everyone an update, the team is working on polishing the existing drivers and dialects before integrating any new ones. Do expect this to be merged before Drizzle ORM v1 though. |
May I ping to ask what the MariaDB situation is? Thanks for an update 🙏 |
i noticed it has been added to v1 roadmap for drizzle-orm, im still waiting for them to support it as well as cockroachdb |
Ah yes, I see MariaDB on the roadmap. Is any particular help needed? Asking due to ixartz/Next-js-Boilerplate#346 (comment) |
seems like its planned after the polishing is done |
(Partially) Addresses #203.
This PR aims to add support for Maria DB, which simply extends the existent MySQL dialect.
Tasks:
mariadb
driver.Other changes implemented:
fullJoin
from MySQL dialect, as neither MySQL nor Maria DB support full joins.Things maybe worth mentioning:
int auto_increment
is used when creating tables in integration tests instead ofserial
because the latter creates abigint
in Maria DB.MySqlDatabase
using themariadb
driver, Planetscale mode is used by default as Maria DB doesn't supportleft join lateral
. (Maria DB Issue).