[Pg] Fixed postgres-js serialization of Date objects #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gp27
force-pushed
the
main
branch
2 times, most recently
from
ccf4fcf to
5039b43
Compare
gp27
force-pushed
the
main
branch
4 times, most recently
from
9b07475 to
33d061a
Compare
Signed-off-by: Gadi Piperno Corcos <[email protected]>
Signed-off-by: Gadi Piperno Corcos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until version 0.29.x it was possible to pass Date objects in queries while using the postgres-js adapter.
Since 0.30.x when PR #1659 was merged, passing a Date object will result in an error:
The "string" argument must be of type string or an instance of Buffer or ArrayBuffer.This PR adds a test to detect the problems and fixes the issues #1993 and #2009.