[PG] Fix fk introspection ordering columns wrongly (critical failure) #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
idk how to add tests proper, only tested this in situ, no idea if the test will run. ci driven development lol. |
Mardoxx
commented
Jan 25, 2025
Comment on lines
+920
to
+921
| columns: [table.ownerId, table.profileImageId], | ||
| foreignColumns: [userProfileImages.ownerId, userProfileImages.id], |
There was a problem hiding this comment.
The order of these matters. Previously it had weird behaviour where it would appear that these were sorted. The information is in the linked issue. Perhaps there is a better way to describe the preconditions
Mardoxx
changed the title
Mardoxx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3993
No idea how to contrib to this, someone can tidy this up if it's wrong.
tl;dr the old implementation was not sympathetic to the order of the columns in the fk relationshops, so when introspecting it would, in some cases, cause the generated SQL to be completely wrong - mismatched columns.