[PG] Allow migration without CREATE SCHEMA permission
#4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the migration uses `CREATE SCHEMA IF NOT EXISTS`, however that requires permission to create a schema even if there's already one. This change allows the migrations to be run by a user without the `CREATE SCHEMA` permission as long as the schema has already been created in advance. This includes a test, that failed before, but works now after the small change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the migration uses
CREATE SCHEMA IF NOT EXISTS, however that requires permission to create a schema even if there's already one. This change allows the migrations to be run by a user without theCREATE SCHEMApermission as long as the schema has already been created in advance.FEATURES
CREATE SCHEMA IF NOT EXISTS.Test Plan
This includes a new test, that creates a restricted user without the
CREATEpermission on the database level, and then tries to migrate using that restricted user. It then cleans up after itself.This did require a minor rewrite of the setup to allow reusing some functionality to create a new DB connection for the restricted user.
Subscribers
Issue
Fixes #2161
Fixes #3353