home: Allow to tweak long-press unfold delay #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the home-bar size from 40px to 15px Replace osk button with powerbar widget and move it to the center Modify the on pressed function to work with long press gesture Use osk-manager directly Add an svg image to represent the new powerbar widget Add both powerbar and arrow into a gtk stack since both are occupying the center region Reuse phosh_home_update_osk_button to switch home-bar stack when dragging Closes: https:// gitlab.gnome.org/World/Phosh/phosh/-/issues/380 Signed-off-by: Bardia Moshiri <[email protected]>
Reduce powerbar opacity to indicate longpress recognition has started And revert back to original state one recognition is successful Add animation to indicate osk non-availability Add haptic feedback to indicate a successful osk interaction Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]> Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]> Signed-off-by: Bardia Moshiri <[email protected]>
* integrate with navbar Signed-off-by: Bardia Moshiri <[email protected]>
* integrate with powerbar Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]>
Signed-off-by: Bardia Moshiri <[email protected]> Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1347>
g7
force-pushed
the
feature/trixie/droidian-experiments
branch
from
8b2c891
to
78f4e4d
Compare
g7
pushed a commit
that referenced
this pull request
Mar 8, 2024
We take a reference the wifi device as we otherwise race with nmclient on shutdown. This fixes the CI tests that otherwise occasionally hit (phosh:674055): GLib-GObject-CRITICAL **: 15:42:34.735: instance with invalid (NULL) class pointer on shutdown with this batcktrace: #0 g_type_check_instance (type_instance=type_instance@entry=0x7f60a86aea90) at ../../../gobject/gtype.c:4290 #1 0x00007f60b1a6fa08 in g_signal_handlers_disconnect_matched (instance=0x7f60a86aea90, mask=mask@entry=G_SIGNAL_MATCH_DATA, signal_id=signal_id@entry=0, detail=detail@entry=0, closure=closure@entry=0x0, func=func@entry=0x0, data=0x7f60a81d8d60) at ../../../gobject/gsignal.c:3085 #2 0x000055dbbbf3b320 in cleanup_wifi_device (self=0x7f60a81d8d60 [PhoshWifiManager]) at ../src/wifimanager.c:634 #3 cleanup_wifi_device (self=0x7f60a81d8d60 [PhoshWifiManager]) at ../src/wifimanager.c:628 #4 phosh_wifi_manager_dispose (object=0x7f60a81d8d60 [PhoshWifiManager]) at ../src/wifimanager.c:752 #5 0x00007f60b1a5a9c0 in g_object_unref (_object=0x7f60a81d8d60) at ../../../gobject/gobject.c:3894 #6 g_object_unref (_object=0x7f60a81d8d60) at ../../../gobject/gobject.c:3805 #7 0x000055dbbbf329ce in phosh_shell_dispose (object=0x7f60a80a92c0 [PhoshShell]) at ../src/shell.c:545 #8 0x00007f60b1a5a9c0 in g_object_unref (_object=0x7f60a80a92c0) at ../../../gobject/gobject.c:3894 #9 g_object_unref (_object=0x7f60a80a92c0) at ../../../gobject/gobject.c:3805 #10 0x000055dbbbf2afb4 in g_assert_finalize_object (object=0x7f60a80a92c0 [PhoshShell]) at /usr/include/glib-2.0/gobject/gobject.h:821 #11 phosh_test_full_shell_thread (data=0x55dbbd233cc0) at ../tests/testlib-full-shell.c:85 #12 0x00007f60b1980a41 in g_thread_proxy (data=0x55dbbd22fc50) at ../../../glib/gthread.c:831 #13 0x00007f60b12163ec in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:444 #14 0x00007f60b1296a5c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 Closes: https://gitlab.gnome.org/World/Phosh/phosh/-/issues/1025 Signed-off-by: Guido Günther <[email protected]> Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1364>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from : https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1346
done by : Guido Günther