增加项目单测 #470
Open
增加项目单测 #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanhom1314
reviewed
Sep 4, 2024
test/pom.xml
Outdated
| <groupId>org.dromara.dynamictp</groupId> | ||
| <artifactId>dynamic-tp-spring</artifactId> | ||
| <version>1.1.8-beta</version> | ||
| <scope>compile</scope> |
| properties.put("spring.dynamic.tp.executors[0].executorType", "common"); | ||
| properties.put("spring.dynamic.tp.globalExecutorProps.executorType","eager"); | ||
| void testBindDtpPropertiesWithMap() throws Exception { | ||
| try { |
| private DtpLifecycleSpringAdapter dtpLifecycleSpringAdapter; | ||
|
|
||
| @Autowired | ||
| private LifeCycleManagement lifeCycleManagement; |
There was a problem hiding this comment.
这个test case 不明确，主要断言的应该是lifeCycleManagement状态是否跟随dtpLifecycleSpringAdapter联动
| DtpLifecycleSupport.initialize(executorWrapper); | ||
|
|
||
| Assertions.assertEquals(initialCorePoolSize, dtpExecutor.getCorePoolSize()); | ||
| Assertions.assertEquals(initialMaxPoolSize, dtpExecutor.getMaximumPoolSize()); |
There was a problem hiding this comment.
断言有点不想关，应该断言的是执行了initialize后，线程池某些字段、状态是否跟预期相同，CorePoolSize、MaximumPoolSize 在initialize里并不会改变，所以这两断言没意义
# Conflicts: # core/src/main/java/org/dromara/dynamictp/core/DtpRegistry.java
# Conflicts: # core/src/main/java/org/dromara/dynamictp/core/DtpRegistry.java # core/src/main/java/org/dromara/dynamictp/core/support/DtpBannerPrinter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.