firmwareError: set hasFirmwareErrorFlag as soon as possible

To avoid reentrance and infinity error loop
dron0gus · Mar 11, 2024 · 0dbd968 · 0dbd968
1 parent 92106db
commit 0dbd968
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/firmware/controllers/core/error_handling.cpp b/firmware/controllers/core/error_handling.cpp
@@ -266,6 +266,7 @@ void firmwareError(ObdCode code, const char *fmt, ...) {
 #if EFI_PROD_CODE
 	if (hasFirmwareErrorFlag)
 		return;
+	hasFirmwareErrorFlag = true;
 #if EFI_ENGINE_CONTROL
 	getLimpManager()->fatalError();
 #endif // EFI_ENGINE_CONTROL
@@ -281,7 +282,6 @@ void firmwareError(ObdCode code, const char *fmt, ...) {
     criticalShutdown();
 	enginePins.communicationLedPin.setValue(1, /*force*/true);
 
-	hasFirmwareErrorFlag = true;
 	if (indexOf(fmt, '%') == -1) {
 		/**
 		 * in case of simple error message let's reduce stack usage