Fixes Issue 33 - 'RegularFileProperty' annotated with @Input cannot determine how to interpret the file

[ivanalvarado]

Description

• Fixes Gradle 8.0 - clearFocus - ClearFocusTask error #33

* What went wrong:
A problem was found with the configuration of task ':clearFocus' (type 'ClearFocusTask').
  - Type 'com.dropbox.focus.ClearFocusTask' property 'focusFile' has @Input annotation used on property of type 'RegularFileProperty'.
    
    Reason: A property of type 'RegularFileProperty' annotated with @Input cannot determine how to interpret the file.
    
    Possible solutions:
      1. Annotate with @InputFile for regular files.
      2. Annotate with @InputFiles for collections of files.
      3. If you want to track the path, return File.absolutePath as a String and keep @Input.
    
    For more information, please refer to https://docs.gradle.org/8.5/userguide/validation_problems.html#incorrect_use_of_input_annotation in the Gradle documentation.

Build Stack

• AGP 8.1.1
• Kotlin 1.9.20
• Gradle 8.5
• focus 0.5.1

[CLAassistant]

All committers have signed the CLA.

[ivanalvarado]

Addresses:

* What went wrong:
A problem was found with the configuration of task ':clearFocus' (type 'ClearFocusTask').
  - Type 'com.dropbox.focus.ClearFocusTask' property 'focusFile' has @Input annotation used on property of type 'RegularFileProperty'.
    
    Reason: A property of type 'RegularFileProperty' annotated with @Input cannot determine how to interpret the file.
    
    Possible solutions:
      1. Annotate with @InputFile for regular files.
      2. Annotate with @InputFiles for collections of files.
      3. If you want to track the path, return File.absolutePath as a String and keep @Input.
    
    For more information, please refer to https://docs.gradle.org/8.5/userguide/validation_problems.html#incorrect_use_of_input_annotation in the Gradle documentation.

[ivanalvarado]

Addresses:

* What went wrong:
Some problems were found with the configuration of task ':clearFocus' (type 'ClearFocusTask').
  - Type 'com.dropbox.focus.ClearFocusTask' property 'focusFile' is annotated with @InputFile but missing a normalization strategy.
    
    Reason: If you don't declare the normalization, outputs can't be re-used between machines or locations on the same machine, therefore caching efficiency drops significantly.
    
    Possible solution: Declare the normalization strategy by annotating the property with either @PathSensitive, @Classpath or @CompileClasspath.
    
    For more information, please refer to https://docs.gradle.org/8.5/userguide/validation_problems.html#missing_normalization_annotation in the Gradle documentation.

https://github.com/gradle/gradle/blob/master/subprojects/core-api/src/main/java/org/gradle/api/tasks/PathSensitivity.java#L50

[ivanalvarado]

This is already addressed here: #42

[nsk90]

@ivanalvarado Hi!, why have you closed the PR? the project seems to be abandoned?

[rharter]

Sorry, this got closed. I'm going to reopen it and pull this in, as it's a good fix and the other PR has been in draft, which is why it hasn't been reviewed.

[WhosNickDoglio]

Sorry that's my fault for not explainig why #42 was stuck in draft and asking for help with the issue I was running into.

I ended up running into this since the .focus file isn't guaranteed to exist or not. I couldn't get any of the workarounds to work in the linked to issue and was going to explore disabling caching for the ClearFocusTask but never got around to it.

The test that was failing in my branch is now failing in main after merging this in

[rharter]

Sorry @WhosNickDoglio, I appreciate your contribution. I noticed the same issue you pointed out after merging, and have that fixed now. There's a new release which has this taken care of. Thanks to both of you for contributing to the project.