Wall #11
Open
Wall #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… address < trapperkeeper@localhost>
ERROR:root:Callback Failed: (501, '<trapperkeeper>: sender address must contain a domain', 'trapperkeeper')
Traceback (most recent call last):
File "build/bdist.linux-x86_64/egg/trapperkeeper/callbacks.py", line 43, in __call__
self._call(*args, **kwargs)
File "build/bdist.linux-x86_64/egg/trapperkeeper/callbacks.py", line 171, in _call
self._send_mail(handler, trap, duplicate)
File "build/bdist.linux-x86_64/egg/trapperkeeper/callbacks.py", line 72, in _send_mail
subject, self.template_env, ctxt)
File "build/bdist.linux-x86_64/egg/trapperkeeper/utils.py", line 127, in send_trap_email
smtp.sendmail(sender, recipients, msg.as_string())
File "/usr/lib/python2.7/smtplib.py", line 731, in sendmail
raise SMTPSenderRefused(code, resp, from_addr)
SMTPSenderRefused: (501, '<trapperkeeper>: sender address must contain a domain', 'trapperkeeper')
|
Looks like you're adding static 3rd party js to the code here. The rest of the code uses cdnjs so you'd want to follow that model and remove those files. Also, a sound effect isn't something I'd be very interested in having so I'd want to see that put under a config flag defaulted to off. How does this respond to not running redis? I don't want to add redis as a required dependency. Any feature that adds this support should be optional and still work well without the websockets. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement the messaging wall