Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container buttons #185

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Container buttons #185

wants to merge 54 commits into from

Conversation

dabbler0
Copy link
Member

Introduces a new Model entity, buttonContainer, which is invisible in the view except that it has buttons at the end of it. The advantage of requiring a container is that it:

  • defines a scope for the button mutation
  • provides reparse boundaries, so that the entire block context doesn't need to always be reparsed, and
  • it usually has semantic meaning, unlike the old arbitrary-token-in-model approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants