-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise exception when injecting into modules #62
Open
janko
wants to merge
1
commit into
dry-rb:main
Choose a base branch
from
janko:raise-for-modules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# frozen_string_literal: true | ||
|
||
module Dry | ||
module AutoInject | ||
Error = Class.new(StandardError) | ||
DuplicateDependencyError = Class.new(Error) | ||
DependencyNameInvalid = Class.new(Error) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'dry/auto_inject/dependency_map' | ||
require 'dry/auto_inject/errors' | ||
|
||
module Dry | ||
module AutoInject | ||
|
@@ -23,6 +24,8 @@ def initialize(container, *dependency_names) | |
|
||
# @api private | ||
def included(klass) | ||
fail Error, "cannot inject dependencies into a module" unless klass.respond_to?(:new) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
define_readers | ||
|
||
define_new | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,10 @@ def initialize(*args) | |
Class.new(child_class) | ||
end | ||
|
||
let(:mod) do | ||
Module.new | ||
end | ||
|
||
context 'with positioned args' do | ||
let(:parent_class) do | ||
Class.new do | ||
|
@@ -167,6 +171,14 @@ def initialize(first, *middle, last) | |
end | ||
end | ||
end | ||
|
||
context 'autoinject in a module' do | ||
it 'raises exception' do | ||
expect { | ||
mod.include Test::AutoInject.args[:one, :two] | ||
}.to raise_error(Dry::AutoInject::Error, /cannot inject/) | ||
end | ||
end | ||
end | ||
|
||
context 'with hash arg' do | ||
|
@@ -312,6 +324,14 @@ def self.included(klass) | |
end | ||
end | ||
end | ||
|
||
context 'autoinject in a module' do | ||
it 'raises exception' do | ||
expect { | ||
mod.include Test::AutoInject.hash[:one, :two] | ||
}.to raise_error(Dry::AutoInject::Error, /cannot inject/) | ||
end | ||
end | ||
end | ||
|
||
context 'with keyword args' do | ||
|
@@ -558,5 +578,13 @@ def initialize(other) | |
end | ||
end | ||
end | ||
|
||
context 'autoinject in a module' do | ||
it 'raises exception' do | ||
expect { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Issue found: Avoid using |
||
mod.include Test::AutoInject.kwargs[:one, :two] | ||
}.to raise_error(Dry::AutoInject::Error, /cannot inject/) | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Always use
raise
to signal exceptions.