New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PrepareDefault#callable! default check with false #101

Open

nbcraft wants to merge 1 commit into dry-rb:main from nbcraft:fix-callable-default-check

nbcraft commented Oct 3, 2022

This PR fixes the callable! check which was not raising when setting default: false, even though it does when setting default: true.

⚠️ This is a breaking change! As it will break for everyone who has set default: false in the past.

I believe this should trigger a major version bump because of it.
Not sure if I need to update changelog and version number myself, lmk and I'll update this PR.

(Note: I re-used some of @skryukov code from #93 for specs shared_examples)


          Fix PrepareDefault#callable! default check with false

25f42db

nbcraft requested a review from solnic as a code owner

October 3, 2022 20:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet