Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert() fixed on Android 10 and new SQLCipher version #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

develhox
Copy link

This commit fix two issues.

First of all, the insert() method was broken on my Pixel 2 XL with the Android 10 update. The convertMapToContentValues() method always returned null. I fixed it by filling the ContentValues explicitly instead of relying on a Parcel. I think this may be a little slower, but at least it works.

I also changed the SQLCipher version to the 4.2.0 to get rid of an annoying log.

@develhox
Copy link
Author

I checked the Parcel source code and I didn't understand why it didn't work anymore. However in the end it does what I am doing, but with more steps, so probably the performance may not be worse in my solution, but even a little better.
By reviewing that code I found a way to improve my solutions, therefore I made a new commit. Instead of cycling on the Map keys and then searching in the map for the corresponding value, I am cycling directly on the entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant