Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADGroup: add SamAccountName parameter #658

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gaelicWizard
Copy link

@gaelicWizard gaelicWizard commented May 22, 2021

Pull Request (PR) description

Adds optional parameter SamAccountName to ADGroup resource to allow setting this property separately. This requires that GroupName be specified using something other than the SamAccountName, e.g. SID, DN, UPN, &c.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

gaelicWizard and others added 3 commits May 22, 2021 18:31
Add SamAccountName property to allow setting the name of the group; this requires that the GroupName property be specified with something other than the SamAccountName (e.g., the SID, DN, &c.).
@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #658 (11a3dd5) into main (9346a1d) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #658   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3412    +4     
===================================
+ Hits       3340   3344    +4     
  Misses       68     68           

@johlju johlju added the needs review The pull request needs a code review. label May 27, 2021
@X-Guardian
Copy link
Contributor

PR #651 must be merged before this PR and it will then need refactoring.

@X-Guardian X-Guardian added on hold The issue or pull request has been put on hold by a maintainer. and removed needs review The pull request needs a code review. labels Jul 4, 2021
@johlju johlju added needs review The pull request needs a code review. and removed on hold The issue or pull request has been put on hold by a maintainer. labels May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants