-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADManagedServiceAccount: Fixed KeberosEncryptionType and TrustedForDelegation on account creation #722
base: main
Are you sure you want to change the base?
Conversation
…ForDelegation on account creation.
…ForDelegation on account creation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
===================================
Coverage 98% 98%
===================================
Files 26 26
Lines 3720 3727 +7
===================================
+ Hits 3651 3658 +7
Misses 69 69
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dasy77)
a discussion (no related file):
Can we try to get the second line covered in unit tests as well? Maybe it is enough to add TrustedForDelegation
here as well?
KerberosEncryptionType = $mockAdServiceAccountStandAlone.KerberosEncryptionType |
@johlju |
@johlju |
Pull Request (PR) description
ADManagedServiceAccount: Set properties KeberosEncryptionType and TrustedForDelegation properly on account creation.
Both properties were not considered previously when the account was created.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
help.
This change is