Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean_WikiContent_For_GitHub_Publish: Fix parsing top level header #164

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Oct 26, 2024

Pull Request (PR) description

  • The task will convert standard hyphens to spaces and Unicode hyphens to standard hyphens before comparison.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (02e340b) to head (86db775).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #164   +/-   ##
===================================
  Coverage    94%    94%           
===================================
  Files        70     70           
  Lines      1324   1325    +1     
===================================
+ Hits       1247   1251    +4     
+ Misses       77     74    -3     
Files with missing lines Coverage Δ
...sks/Clean_WikiContent_For_GitHub_Publish.build.ps1 81% <100%> (+10%) ⬆️

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 10f93b3 into dsccommunity:main Oct 26, 2024
14 checks passed
@johlju johlju deleted the fix/issue-160 branch October 26, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean_WikiContent_For_GitHub_Publish: Update task to handle top header with spaces
1 participant