Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlAuditSpecification: New resources #1779

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 9, 2022

Pull Request (PR) description

  • SqlServerDsc
    • Add new resource SqlAuditSpecification.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Aug 9, 2022
@johlju johlju mentioned this pull request Aug 10, 2022
9 tasks
@github-actions
Copy link

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@github-actions github-actions bot added the abandoned The pull request has been abandoned. label Aug 26, 2022
@johlju johlju force-pushed the f/add-resource-SqlAuditSpecification branch from 3100916 to c56a834 Compare March 26, 2023 14:49
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #1779 (fe3a7cf) into main (c780423) will decrease coverage by 4%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           main   #1779    +/-   ##
=====================================
- Coverage    92%     88%    -4%     
=====================================
  Files        85      86     +1     
  Lines      7640    7925   +285     
=====================================
  Hits       7038    7038            
- Misses      602     887   +285     
Flag Coverage Δ
unit 88% <0%> (-4%) ⬇️
Impacted Files Coverage Δ
...Specification/DSC_SqlServerAuditSpecification.psm1 0% <0%> (ø)

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. abandoned The pull request has been abandoned. labels Mar 26, 2023
@johlju johlju marked this pull request as ready for review March 26, 2023 18:05
@johlju
Copy link
Member Author

johlju commented Mar 26, 2023

Will add the missing unit tests to this one.

@github-actions
Copy link

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@github-actions github-actions bot added the abandoned The pull request has been abandoned. label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned. waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant