Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Fix workspace settings #1948

Merged
merged 2 commits into from
Jul 12, 2023
Merged

SqlServerDsc: Fix workspace settings #1948

merged 2 commits into from
Jul 12, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 9, 2023

Pull Request (PR) description

  • SqlServerDsc
    • Fix a path in VS Code workspace settings to correctly use Script Analyzer on Linux and macOS.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jul 9, 2023
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #1948 (44d1d7e) into main (527dcd4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1948   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        92      92           
  Lines      7810    7810           
====================================
  Hits       7185    7185           
  Misses      625     625           
Flag Coverage Δ
unit 91% <ø> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit ac5c0eb into main Jul 12, 2023
32 checks passed
@johlju johlju deleted the fix/workspace-settings branch July 12, 2023 08:22
@johlju johlju removed the needs review The pull request needs a code review. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant