Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabasePermission/ServerPermission: Fix ToString() method #1997

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 17, 2024

Pull Request (PR) description

  • SqlDatabasePermission
    • New method ToString() for making verbose output better.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner January 17, 2024 14:33
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e67e58) 94% compared to head (eb9618a) 94%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1997   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        93      93           
  Lines      7844    7848    +4     
====================================
+ Hits       7424    7428    +4     
  Misses      420     420           
Flag Coverage Δ
unit 94% <100%> (+<1%) ⬆️
Files Coverage Δ
source/Classes/002.DatabasePermission.ps1 100% <100%> (ø)
source/Classes/002.ServerPermission.ps1 100% <100%> (ø)

@johlju johlju changed the title SqlDatabasePermission: Fix ToString() method DatabasePermission/ServerPermission: Fix ToString() method Jan 17, 2024
@johlju johlju added the needs review The pull request needs a code review. label Jan 18, 2024
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit c26c06f into dsccommunity:main Jan 19, 2024
36 checks passed
@johlju johlju deleted the f/fix-ToString-method branch January 19, 2024 14:34
@johlju johlju removed the needs review The pull request needs a code review. label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant