Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Split test pipeline into different stages #2027

Merged
merged 9 commits into from
May 8, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented May 8, 2024

Pull Request (PR) description

  • SqlServerDsc
    • The pipeline test stages has been split into different stages.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner May 8, 2024 14:35
@johlju johlju changed the title SqlServerDsc: SqlServerDsc: Split test pipeline into different stages May 8, 2024
@johlju johlju added the needs review The pull request needs a code review. label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (026647c) to head (19c10ce).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2027   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        93      93           
  Lines      7862    7862           
====================================
  Hits       7442    7442           
  Misses      420     420           
Flag Coverage Δ
unit 94% <ø> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 62 of 62 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit c9de1bf into dsccommunity:main May 8, 2024
44 checks passed
@johlju johlju deleted the f/new-test-stages branch May 8, 2024 18:45
@johlju johlju removed the needs review The pull request needs a code review. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant