Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Initial integration tests for commands #2028

Merged
merged 41 commits into from
May 11, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented May 9, 2024

Pull Request (PR) description

  • SqlServerDsc
    • Initial integration tests for commands

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 84.84848% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 94%. Comparing base (026647c) to head (5385af0).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2028   +/-   ##
====================================
- Coverage    94%     94%   -1%     
====================================
  Files        93      94    +1     
  Lines      7862    7919   +57     
====================================
+ Hits       7442    7489   +47     
- Misses      420     430   +10     
Flag Coverage Δ
unit 94% <84%> (-1%) ⬇️
Files Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 96% <ø> (ø)
source/Public/Add-SqlDscNode.ps1 100% <100%> (ø)
source/Public/Complete-SqlDscFailoverCluster.ps1 100% <100%> (ø)
source/Public/Complete-SqlDscImage.ps1 100% <100%> (ø)
source/Public/Initialize-SqlDscRebuildDatabase.ps1 100% <100%> (ø)
source/Public/Install-SqlDscServer.ps1 100% <100%> (ø)
source/Public/Remove-SqlDscNode.ps1 100% <100%> (ø)
source/Public/Repair-SqlDscServer.ps1 100% <100%> (ø)
source/Public/Uninstall-SqlDscServer.ps1 100% <100%> (ø)
source/Private/Invoke-SetupAction.ps1 90% <60%> (-2%) ⬇️
... and 1 more

@johlju johlju force-pushed the f/initia-integ-test-commands branch from c867775 to ae720d5 Compare May 9, 2024 16:38
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r2, 25 of 25 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Github-advanced-security[bot])


source/Public/Save-SqlDscSqlServerMedia.ps1 line 60 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Use space after open brace.

Show more details

Done.


source/Public/Save-SqlDscSqlServerMedia.ps1 line 60 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Use space before closing brace.

Show more details

Done.


source/Public/Save-SqlDscSqlServerMedia.ps1 line 209 at r2 (raw file):

Previously, github-advanced-security[bot] wrote…

throw is used to terminate a function outside of try in the function Save-SqlDscSqlServerMedia.

Show more details

Done.

@johlju johlju marked this pull request as ready for review May 11, 2024 17:48
@johlju johlju requested a review from a team as a code owner May 11, 2024 17:48
@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels May 11, 2024
@johlju
Copy link
Member Author

johlju commented May 11, 2024

This integration test is good enough for now, it can be improved upon in the future, but should be a good starting point for creating additional test for other commands.

@johlju johlju merged commit a5c29fe into dsccommunity:main May 11, 2024
42 of 44 checks passed
@johlju johlju deleted the f/initia-integ-test-commands branch May 11, 2024 18:04
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: Move integration tests for tests/Integration/Resources
1 participant