-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerDsc: Initial integration tests for commands #2028
SqlServerDsc: Initial integration tests for commands #2028
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
====================================
- Coverage 94% 94% -1%
====================================
Files 93 94 +1
Lines 7862 7919 +57
====================================
+ Hits 7442 7489 +47
- Misses 420 430 +10
|
c867775
to
ae720d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2, 25 of 25 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Github-advanced-security[bot])
source/Public/Save-SqlDscSqlServerMedia.ps1
line 60 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Use space after open brace.
Done.
source/Public/Save-SqlDscSqlServerMedia.ps1
line 60 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Use space before closing brace.
Done.
source/Public/Save-SqlDscSqlServerMedia.ps1
line 209 at r2 (raw file):
Previously, github-advanced-security[bot] wrote…
throw is used to terminate a function outside of try in the function Save-SqlDscSqlServerMedia.
Done.
This integration test is good enough for now, it can be improved upon in the future, but should be a good starting point for creating additional test for other commands. |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
tests/Integration/Resources
#1838Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is