- [CLI]: Bug: Doesn't run a dev environment if code is not configured…

… in PATH #612
dstackai · Aug 2, 2023 · a57f463 · a57f463
1 parent d620ba2
commit a57f463
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/cli/dstack/_internal/configurators/dev_environment.py b/cli/dstack/_internal/configurators/dev_environment.py
@@ -29,7 +29,9 @@ def get_jobs(
         run_plan: Optional[RunPlan] = None,
     ) -> List[job.Job]:
         self.ide = VSCodeDesktop(
-            extensions=["ms-python.python", "ms-toolsai.jupyter"], run_name=run_name
+            extensions=["ms-python.python", "ms-toolsai.jupyter"],
+            run_name=run_name,
+            run_plan=run_plan,
         )
         self.sshd = SSHd(ssh_key_pub)
         self.sshd.map_to_port = get_map_to_port(self.ports(), self.sshd.port)

diff --git a/cli/dstack/_internal/configurators/extensions/vscode.py b/cli/dstack/_internal/configurators/extensions/vscode.py
@@ -3,16 +3,21 @@
 
 from dstack._internal.cli.utils.common import console
 from dstack._internal.configurators.extensions import IDEExtension
+from dstack._internal.core.plan import RunPlan
 
 
 class VSCodeDesktop(IDEExtension):
     def __init__(
-        self, extensions: List[str], version: Optional[str] = None, run_name: Optional[str] = None
+        self,
+        extensions: List[str],
+        version: Optional[str] = None,
+        run_name: Optional[str] = None,
+        run_plan: Optional[RunPlan] = None,
     ):
         self.extensions = extensions
         if version is None:
             version = self._detect_code_version()
-        if version is None:
+        if version is None and run_plan is None:
             console.print(
                 "[grey58]Unable to detect the VS Code version and pre-install extensions. "
                 "Fix by opening [sea_green3]Command Palette[/sea_green3], executing [sea_green3]Shell Command: "