[dind] Move dind processes to a separate cgroup #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
un-def
force-pushed
the
issue_1854_dind_resource_consraints
branch
from
9c36231
to
c735527
Compare
r4victor
reviewed
Oct 18, 2024
docker/dind/start-dockerd
Outdated
Comment on lines
25
to
30
| move_processes_to_nested_cgroup() { | ||
| # detect cgroups v2 | ||
| if [[ -f /sys/fs/cgroup/cgroup.controllers ]]; then | ||
| local group=/sys/fs/cgroup/dind | ||
| mkdir -p ${group} | ||
| xargs -rn1 < /sys/fs/cgroup/cgroup.procs > ${group}/cgroup.procs || true |
There was a problem hiding this comment.
It would be really helpful to comment why nesting is necessary because it's super non-obvious. As I understand, we cannot have a parent group with running processes, so we move them into a "dummy" nested group?
r4victor
approved these changes
Oct 18, 2024
un-def
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/moby/moby/blob/65cfcc2/hack/dind#L59
See: https://github.com/earthly/earthly/blob/08b0d1f/buildkitd/dockerd-wrapper.sh#L63
Fixes: #1854