Configuring if service path prefix is stripped #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the `strip_prefix` setting to allow configuring whether the path prefix is stripped when forwarding requests to services without a gateway. - Update `URLReplacer` to not add the prefix to URLs that already have it. If a web app is configured to run with a prefix, it can log its URLs with the prefix, so `dstack` shouldn't add the prefix for the second time. - Add a Dash example to docs.
un-def
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strip_prefixsetting to allow configuring whether the path prefix is stripped when forwarding requests to services without a gateway.URLReplacerto not add the prefix to URLs that already have it. If a web app is configured to run with a prefix, it can log its URLs with the prefix, sodstackshouldn't add the prefix for the second time.Closes #2250