Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssh fleet and gateway configuration change detection #2258

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

r4victor
Copy link
Collaborator

@r4victor r4victor commented Feb 3, 2025

Fixes #2222
Fixes #2161

Not security critical since we only pinged backed what we got.
The fix is needed so that current run spec and new run spec can be compared for changes.
@r4victor r4victor merged commit 1d2ae34 into master Feb 3, 2025
24 checks passed
@r4victor r4victor deleted the issue_2222_configuration_changes branch February 3, 2025 11:36
pranitnaik43 pushed a commit to bahaal-tech/dstack that referenced this pull request Feb 9, 2025
* Remove ssh key data from fleet plan

Not security critical since we only pinged backed what we got.
The fix is needed so that current run spec and new run spec can be compared for changes.

* Do not detect gateway configuration changes on default changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant