Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #2966 local_solar_time #3008

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Feature #2966 local_solar_time #3008

wants to merge 14 commits into from
+629 −327

Commits on Nov 4, 2024

  1. Per #2966, add new solar_time() function to the vx_solar library.

    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2c13fda View commit details
    Browse the repository at this point in the history

  2. Per #2966, add support for new solar_time masking type. Also make log… 

    … messages for consistent and eliminate the warning about -thresh not being specified becuase its fine to not specify a threshold.
    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4b469d6 View commit details
    Browse the repository at this point in the history

  3. Per #2966, add a units attribute to the output NetCDF mask variable.

    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2328400 View commit details
    Browse the repository at this point in the history

  4. Per #2966, modify solar azimuth and altitude strings to make the log … 

    …messages align well.
    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ea9840d View commit details
    Browse the repository at this point in the history

  5. Per #2966, add gen_vx_mask unit test to demonstrate the solar_time ma… 

    …sking type.
    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0ed3fe2 View commit details
    Browse the repository at this point in the history

  6. Per #2966, add documentation about the -solar_time option

    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2a32e45 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Per #2966, reduce SonarQube code smells in gen_vx_mask

    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8734801 View commit details
    Browse the repository at this point in the history

  2. Per #2966, reduce SonarQube findings

    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e865e98 View commit details
    Browse the repository at this point in the history

  3. Per #2966, support multiple mask types with the same mask field being… 

    … supported in a single run. Still need to update the user's guide.
    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a64930f View commit details
    Browse the repository at this point in the history

  4. Per #2966, add UTC

    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    42ff3cf View commit details
    Browse the repository at this point in the history

  5. Per #2966, update gen_vx_mask docs about supporting multiple -type op… 

    …tions in a single run
    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b1268a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Per #2966, update logic to fix using data masking twice, add a unit t… 

    …est to demonstrate, and update the mask_type attribute to include the magic string for the gridded data used for data masking.
    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4ff2c26 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature_2966_local_solar_time' of https://github.com/dt… 

    …center/MET into feature_2966_local_solar_time
    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    120d132 View commit details
    Browse the repository at this point in the history

  3. Per #2966, adjust the logic slightly to revert to existing behavior w… 

    …here we only write the timing information of the input data to the gen_vx_mask output when no threshold was applied. This should reduce the number of diffs flagged by PR #3008
    @JohnHalleyGotway
    JohnHalleyGotway committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0177be5 View commit details
    Browse the repository at this point in the history