-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2877 v6.1.0-beta1 release #2878
Conversation
…o be marked as pass because no extenral testing required, removed SonarQube complaints about duplicate string literals
* Confirm 6.0.0 Docker images are auto-generated for dtcenter/metplus and metplus-analysis | ||
(`#2756 <https://github.com/dtcenter/METplus/issues/2756>`_) | ||
* Refine testing GitHub Action workflow dispatch functionality | ||
(`#2816 <https://github.com/dtcenter/METplus/issues/2816>`_) | ||
|
||
.. _upgrade-instructions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgemccabe I suspect these upgrade instructions are actually for upgrading to the previous version, 6.0.0, rather than the new version, 6.1.0. @jprestop directed me to rework them for the new MET version. By way of example, here's the MET-12.0.0 Upgrade Instructions versus the ones for MET-12.1.0-beta1. I defined "types" of upgrade info and added a dropdown with details about each type.
I don't think you NEED to necessarily modify the upgrade instructions for the beta1 release, but you should modify them eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of these METplus-12.1.0-Beta1 release notes. Please see the note I added about upgrade instructions. Totally up to you if you'd like to make any changes today or handle it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this through google grammar and spell check. And I read through it. I couldn't find any typos.
I did not review the generate_release_notes.py
Good job! I approve.
Besides adding the release notes and updating the version file, I made some updates to the script to help generate release notes and entries to the release acceptance testing discussion. This can be ignored in your review.
Review release notes here:
https://metplus.readthedocs.io/en/feature_2877_v6.1.0-beta1/Users_Guide/release-notes.html#metplus-version-6-1-0-beta-1-release-notes-2025-01-28