Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2877 v6.1.0-beta1 release #2878

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Conversation

georgemccabe
Copy link
Collaborator

Besides adding the release notes and updating the version file, I made some updates to the script to help generate release notes and entries to the release acceptance testing discussion. This can be ignored in your review.

Review release notes here:
https://metplus.readthedocs.io/en/feature_2877_v6.1.0-beta1/Users_Guide/release-notes.html#metplus-version-6-1-0-beta-1-release-notes-2025-01-28

@georgemccabe georgemccabe added this to the METplus-6.1.0 milestone Jan 28, 2025
@georgemccabe georgemccabe linked an issue Jan 28, 2025 that may be closed by this pull request
@georgemccabe georgemccabe marked this pull request as ready for review January 28, 2025 19:36
@georgemccabe georgemccabe requested review from lisagoodrich and JohnHalleyGotway and removed request for lisagoodrich January 28, 2025 19:36
* Confirm 6.0.0 Docker images are auto-generated for dtcenter/metplus and metplus-analysis
(`#2756 <https://github.com/dtcenter/METplus/issues/2756>`_)
* Refine testing GitHub Action workflow dispatch functionality
(`#2816 <https://github.com/dtcenter/METplus/issues/2816>`_)

.. _upgrade-instructions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgemccabe I suspect these upgrade instructions are actually for upgrading to the previous version, 6.0.0, rather than the new version, 6.1.0. @jprestop directed me to rework them for the new MET version. By way of example, here's the MET-12.0.0 Upgrade Instructions versus the ones for MET-12.1.0-beta1. I defined "types" of upgrade info and added a dropdown with details about each type.

I don't think you NEED to necessarily modify the upgrade instructions for the beta1 release, but you should modify them eventually.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these METplus-12.1.0-Beta1 release notes. Please see the note I added about upgrade instructions. Totally up to you if you'd like to make any changes today or handle it in the future.

Copy link
Contributor

@lisagoodrich lisagoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this through google grammar and spell check. And I read through it. I couldn't find any typos.
I did not review the generate_release_notes.py

Good job! I approve.

@georgemccabe georgemccabe merged commit bab41ea into develop Jan 28, 2025
61 of 69 checks passed
@georgemccabe georgemccabe deleted the feature_2877_v6.1.0-beta1 branch January 28, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create the METplus v6.1.0-beta1 release
3 participants