Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature internal 29 unique logging #549

Merged
merged 18 commits into from
Oct 12, 2024

Conversation

ishita9
Copy link

@ishita9 ishita9 commented Oct 11, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Junit tests passed for the added changes. Ran METviewer through docker instance and loaded data from sql/mv_mysql.sql copied from METdataio. Verified that the log output from /opt/vxwww/tomcat/logs/myservlet.log and /opt/tomcat/logs/catalina.out have the format as per the STIG requirements
Screenshot 2024-10-11 at 3 26 00 PM
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Detailed instructions in this googledoc file : url

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No] No

  • Do these changes include sufficient testing updates? [Yes or No] No

  • Will this PR result in changes to the test suite? [Yes or No]
    No
    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]
    No
    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METviewer-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@ishita9 ishita9 requested a review from bikegeek October 11, 2024 22:12
Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in docker container and verified the addition of the colored text indicating the hostname, location of code, and "METviewer" identifier

@bikegeek bikegeek merged commit f1e5024 into develop Oct 12, 2024
5 checks passed
@bikegeek bikegeek deleted the feature_internal_29_unique_logging branch October 12, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants