-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature internal 29 unique logging #549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o read the hostname and put it into the logging context.
bikegeek
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in docker container and verified the addition of the colored text indicating the hostname, location of code, and "METviewer" identifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Junit tests passed for the added changes. Ran METviewer through docker instance and loaded data from sql/mv_mysql.sql copied from METdataio. Verified that the log output from /opt/vxwww/tomcat/logs/myservlet.log and /opt/tomcat/logs/catalina.out have the format as per the STIG requirements
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Detailed instructions in this googledoc file : url
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No] No
Do these changes include sufficient testing updates? [Yes or No] No
Will this PR result in changes to the test suite? [Yes or No]
No
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes or No]
No
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METviewer-X.Y.Z Development project for official releases