Sort out clone machine edge cases

[scravy]

The clone machine does trivial transformations of the bitcoin codebase. For example it renames bitcoin into unit-e where it's safe to do so.

Occasionally it renames some things (all in documentation, READMEs and such) which it shouldn't – for instance it renames names of python packages like python-bitcoinlib to things which actually should not exist.

These should be changed back manually (it's not a terribly lot) and blacklisted in the clone machine. The clone machine already features mechanisms to black list certain items.

[cornelius]

We have an additional mechanism to replace files by the unit-e version now. This covers some of the mentioned edge cases such as the README (and some more files).

We do have to look at the remaining cases where things are renamed which shouldn't and cover them in the blacklists and such.

I would suggest to do that once we have the final naming in place (dtr-org/unit-e#228) and we have adapted clonemachine to do the renaming accordingly (i.e. issue https://github.com/dtr-org/unit-e/issues/296).

[cornelius]

One more corner-case: In the help texts of the RPC commands there are various occurrences of "unite address". These should probably rather be "Unit-e address".

[cornelius]

Some more edge cases to fix:

• https://github.com/dtr-org/unit-e/blame/master/doc/zmq.md#L105
• https://github.com/dtr-org/unit-e/blame/master/doc/shared-libraries.md#L46
• https://github.com/dtr-org/unit-e/blame/master/doc/README.md#L34
• https://github.com/dtr-org/unit-e/blame/master/doc/README.md#L65
• Links to BIPs and bitcoin pull requests in https://github.com/dtr-org/unit-e/blob/master/doc/bips.md (and possibly other files as well)
• Links to IRC in https://github.com/dtr-org/unit-e/blob/master/doc/README.md (and possibly other files as well)
• Link to unit-e git repo in https://github.com/dtr-org/unit-e/blame/master/doc/build-netbsd.md#L28 (and possibly other files as well)
• https://github.com/dtr-org/unit-e/blob/master/doc/Doxyfile.in#L1268
• https://github.com/dtr-org/unit-e/blob/master/doc/Doxyfile.in#L1276
• https://github.com/dtr-org/unit-e/blame/master/doc/README.md#L27
• Link to the Wiki at https://github.com/dtr-org/unit-e/blame/master/doc/README.md#L31 (and possibly other files as well)
• https://github.com/dtr-org/unit-e/blame/master/doc/translation_process.md#L4 (there are more of this in this file and https://github.com/dtr-org/unit-e/blob/master/doc/translation_strings_policy.md
• https://github.com/dtr-org/unit-e/blame/master/doc/benchmarking.md#L9
• https://github.com/dtr-org/unit-e/blame/master/doc/build-windows.md#L141 and https://github.com/dtr-org/unit-e/blame/master/doc/build-windows.md#L143 (should be unit-e, not unite)

[cornelius]

One more edge case: doc/README_windows.txt has CRLF line endings in bitcoin. Clonemachine converts that to CR. As this file is put into the Windows installer we probably need to keep the CRLF line endings there.

[cornelius]

Most of the edge cases have been resolved now. This is a summary of what is left to do:

• References to bitcointalk.org, and the #bitcoin channel on IRC should not be touched to avoid merge conflicts.
• References to the bitcoin git repository are not replaced anymore. This is generally correct because it usually refers to code pieces, issues, or pull requests which are actually in bitcoin. There are some cases where we need to replace them by references to the unit-e repository, e.g. in build instructions (example: doc/build-netbsd.md).
• Substitution of the values of DOCSET_BUNDLE_ID and DOCSET_PUBLISHER_ID in doc/Doxyfile has to be corrected.
• In doc/benchmarking there is a mention of "bitcoin-core". This should be substituted to "unit-e".
• The CRLF line endings of doc/README_windows.txt should be preserved.