Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup developer docs #646

Merged
merged 14 commits into from
Feb 21, 2019
Merged

Cleanup developer docs #646

merged 14 commits into from
Feb 21, 2019

Conversation

cornelius
Copy link
Member

This PR cleans up the developer documentation in the doc directory. It fixes naming, URLs, and adapts texts to unit-e.

The BIPs file, references to the mailing list, and the Windows build data need a follow up (see #641, #640, #639). I would like to consider that out of the scope of this pull request, though.

The release and translation process documents need an update as well but we can better do that when we have defined these processes and done releases and translations. There is a note in these files in this regard.

The pull request contains a series of patches. There is a bit of context in the commit messages. It might be easier to review the pull request by looking at the commits instead of the complete file diff. It's up to your preferences, though :-)

The Bitcoin Core release notes don't directly apply to unit-e. We
will have our own release notes. Upstream release notes are available
from the Bitcoin Core repository at
https://github.com/bitcoin/bitcoin/tree/master/doc/release-notes.

Signed-off-by: Cornelius Schumacher <[email protected]>
* Replace `UnitE` by `Unit-e`
* Replace `UnitE Core` by `unit-e`

Signed-off-by: Cornelius Schumacher <[email protected]>
* Remove information which does not apply to unit-e
* Add reference to Bitcoin Core copyright
* Add note about docs being inherited from upstream

Signed-off-by: Cornelius Schumacher <[email protected]>
Signed-off-by: Cornelius Schumacher <[email protected]>
* Add introduction
* Remove versioning information and only keep the info which is
  valid for the current version

Signed-off-by: Cornelius Schumacher <[email protected]>
We will need to add out own release notes once we start doing
releases. Remove the Bitcoin Core release notes for now.

Signed-off-by: Cornelius Schumacher <[email protected]>
Signed-off-by: Cornelius Schumacher <[email protected]>
* Fix API version number to reflect what is in the code
* Fix links to BIPs
* Remove example implementation which only exist for Bitcoin

Signed-off-by: Cornelius Schumacher <[email protected]>
Signed-off-by: Cornelius Schumacher <[email protected]>
Signed-off-by: Cornelius Schumacher <[email protected]>
Signed-off-by: Cornelius Schumacher <[email protected]>
Signed-off-by: Cornelius Schumacher <[email protected]>
@cornelius cornelius added the documentation Documentation label Feb 19, 2019
@cornelius cornelius added this to the 0.1 milestone Feb 19, 2019
@cornelius
Copy link
Member Author

Some of the changes, especially the naming changes, need some adaptions of clonemachine so that the next upstream sync doesn't create too many conflicts. There is an open WIP pull request to adapt the naming (https://github.com/dtr-org/clonemachine/pulls), and a few issues to adapt the other cases (dtr-org/unit-e-clonemachine#25, dtr-org/unit-e-clonemachine#23, dtr-org/unit-e-clonemachine#21).

Signed-off-by: Cornelius Schumacher <[email protected]>
@scravy
Copy link
Member

scravy commented Feb 19, 2019

ACK add0411

@scravy scravy requested review from a team February 19, 2019 16:03
doc/zmq.md Outdated Show resolved Hide resolved
Copy link
Member

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other that United, utACK add0411

Signed-off-by: Cornelius Schumacher <[email protected]>
Copy link
Member

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b5084d9

Copy link

@castarco castarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b5084d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants