Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old and irrelevant files #115

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Remove old and irrelevant files #115

merged 1 commit into from
Apr 29, 2019

Conversation

Gnappuraz
Copy link
Member

This PR removes what I think is either outdated or not relevant for the repo anymore. Especially for spec_v1.0.md it contains outdated informations that can be quite misleading, I will create a new and up to date version of it. As for /particl/create_tx.md I think is not relevant at all at this point and should simply be removed.

Signed-off-by: Matteo Sumberaz <[email protected]>
@Gnappuraz Gnappuraz requested a review from a team April 23, 2019 12:17
@Gnappuraz Gnappuraz self-assigned this Apr 23, 2019
@Gnappuraz Gnappuraz added the documentation Documentation label Apr 23, 2019
Copy link

@castarco castarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 983f410

@kostyantyn kostyantyn requested a review from cmihai April 23, 2019 12:29
@cmihai
Copy link
Member

cmihai commented Apr 23, 2019

Concept ACK, but signal_callback_system.md still seems relevant?

Copy link
Member

@kostyantyn kostyantyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 983f410

@AM5800
Copy link
Member

AM5800 commented Apr 23, 2019

I join @cmihai: what is wrong with signal_callback_system.md?

@Gnappuraz
Copy link
Member Author

That signal_callback_system.md is incomplete and incorrect in some parts. Also is more bitcoin internals than stuff relevant to us. I'd rather remove it cause on its own also is a bit silly honestly, and not so useful.

Copy link
Member

@AM5800 AM5800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 983f410

@cornelius
Copy link
Member

The esperanza spec is linked from the Unit-e README. This needs to be corrected then as well. Would be good to have this information in the docs. We have an open issue for that (dtr-org/docs.unit-e.io#22).

@Gnappuraz
Copy link
Member Author

Gnappuraz commented Apr 24, 2019

@cornelius I'd rather get rid of it now, update it asap and republish it. Atm is really outdated on some parts, people reading it would just be confused I guess. We can directly republish it in the docs then.

@cornelius
Copy link
Member

@Gnappuraz I'm fine with removing the files now as long as we make sure we don't end up with broken links in the unit-e README.

@Gnappuraz
Copy link
Member Author

@cornelius I created a PR on unit-e to get rid of the links.

Copy link
Member

@cornelius cornelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 983f410

@Gnappuraz Gnappuraz merged commit 5dcea5f into dtr-org:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants