-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old and irrelevant files #115
Conversation
Signed-off-by: Matteo Sumberaz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 983f410
Concept ACK, but signal_callback_system.md still seems relevant? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 983f410
I join @cmihai: what is wrong with |
That |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 983f410
The esperanza spec is linked from the Unit-e README. This needs to be corrected then as well. Would be good to have this information in the docs. We have an open issue for that (dtr-org/docs.unit-e.io#22). |
@cornelius I'd rather get rid of it now, update it asap and republish it. Atm is really outdated on some parts, people reading it would just be confused I guess. We can directly republish it in the docs then. |
@Gnappuraz I'm fine with removing the files now as long as we make sure we don't end up with broken links in the unit-e README. |
@cornelius I created a PR on unit-e to get rid of the links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 983f410
This PR removes what I think is either outdated or not relevant for the repo anymore. Especially for
spec_v1.0.md
it contains outdated informations that can be quite misleading, I will create a new and up to date version of it. As for/particl/create_tx.md
I think is not relevant at all at this point and should simply be removed.