Skip to content

Commit

Permalink
bug fix
Browse files Browse the repository at this point in the history
  • Loading branch information
shoubhikraj committed Jul 17, 2024
1 parent 076bad6 commit c9286b3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion autode/opt/optimisers/crfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def _step(self) -> None:
self._take_step_within_max_move(delta_s)
return None

def _take_step_within_max_move(self, delta_s):
def _take_step_within_max_move(self, delta_s: np.ndarray):
"""
Take the step by converting internal coordinates to Cartesian
coordinates, and scaling back if the maximum movement of an
Expand Down
2 changes: 1 addition & 1 deletion tests/test_opt/test_crfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ def test_composite_bond_constraint():
def test_trust_radius_limits():
import autode.opt.optimisers.crfo

max_lim = autode.opt.optimisers.crfo._max_trust
max_lim = autode.opt.optimisers.crfo.MAX_TRUST
opt = CRFOptimiser(
maxiter=10, gtol=1e-3, etol=1e-4, init_trust=max_lim + 0.1
)
Expand Down

0 comments on commit c9286b3

Please sign in to comment.