Skip to content

Commit

Permalink
Merge pull request #483 from duckdb/guenp/fix-flaky-test
Browse files Browse the repository at this point in the history
Use tmp_path instead of tmp_path_factory to see if it helps fix flaky file-based test
  • Loading branch information
jwills authored Dec 4, 2024
2 parents 9f9cdb1 + 3d69c4d commit 99e4e53
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def bv_server_process(profile_type):
# The profile dictionary, used to write out profiles.yml
# dbt will supply a unique schema per test, so we do not specify 'schema' here
@pytest.fixture(scope="session")
def dbt_profile_target(profile_type, bv_server_process, tmp_path_factory):
def dbt_profile_target(profile_type, bv_server_process, tmpdir_factory):
profile = {"type": "duckdb", "threads": 4}

if profile_type == "buenavista":
Expand All @@ -69,7 +69,7 @@ def dbt_profile_target(profile_type, bv_server_process, tmp_path_factory):
"user": "test",
}
elif profile_type == "file":
profile["path"] = str(tmp_path_factory.getbasetemp() / "tmp.db")
profile["path"] = str(tmpdir_factory.mktemp("dbs") / "tmp.db")
elif profile_type == "md":
# Test against MotherDuck
if MOTHERDUCK_TOKEN not in os.environ and MOTHERDUCK_TOKEN.lower() not in os.environ:
Expand Down

0 comments on commit 99e4e53

Please sign in to comment.