Make grant configs a no-op for DuckDB #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guenp
approved these changes
Oct 10, 2024
| {% macro duckdb__apply_grants(relation, grant_config, should_revoke=True) %} | ||
| {#-- If grant_config is {} or None, this is a no-op --#} | ||
| {% if grant_config %} | ||
| {{ log("Grants are not (currently!) supported for DuckDB", info=True) }} |
There was a problem hiding this comment.
Suggested change
| {{ log("Grants are not (currently!) supported for DuckDB", info=True) }} | |
| {{ log("Grants defined on relation ~ relation.render() ~ not (currently!) supported for DuckDB", info=True) }} |
There was a problem hiding this comment.
ah this is a good call but I think it's missing some quotes in there-- will tweak it to include the relation info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #458