Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FireDucks #80

Closed
wants to merge 1 commit into from
Closed

Conversation

masashi-kotera
Copy link

@masashi-kotera masashi-kotera commented Jun 19, 2024

We measured the performance of db-benchmark using our new dataframe library FireDucks (https://fireducks-dev.github.io/).
If everything looks good, can you please add FireDucks to this benchmark.

@masashi-kotera masashi-kotera changed the title add FireDucks Add FireDucks Jun 19, 2024
@Tmonster Tmonster self-requested a review June 24, 2024 08:33
@Tmonster
Copy link
Collaborator

Thank you! Will take a look sometime this week

@Tmonster
Copy link
Collaborator

Hi @masashi-kotera,

Thanks again for the PR. In the interest of transparency and fairness, I cannot merge these results until the FireDucks implementation is open source. I understand that this policy is not clearly stated on the README.md, but the report does have as a first sentence "This page aims to benchmark various database-like tools popular in open-source data science".

If the FIreDucks Implementation does become open-source, feel free to re-open this PR or create another one.

Regards,
Tom Ebergen

@Tmonster Tmonster closed this Jun 24, 2024
@masashi-kotera
Copy link
Author

Hi @Tmonster,

I appreciate you checking our PR.
Although this result was disappointing for us, we will contact you again when Fireducks becomes OSS.

Regards,
masashi-kotera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants