Fixed experiment pixel metrics

duckduckgo · Feb 26, 2025 · 1a9b61e · 1a9b61e
1 parent ab08821
commit 1a9b61e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/...src/main/java/com/duckduckgo/subscriptions/impl/freetrial/FreeTrialExperimentDataStore.kt b/...src/main/java/com/duckduckgo/subscriptions/impl/freetrial/FreeTrialExperimentDataStore.kt
@@ -41,6 +41,11 @@ interface FreeTrialExperimentDataStore {
      * Returns the number [Int] of paywall impressions for the given [definition]
      */
     suspend fun getMetricForPixelDefinition(definition: PixelDefinition): Int
+
+    /**
+     * Increases the count of paywall impressions for the given [definition]
+     */
+    suspend fun increaseMetricForPixelDefinition(definition: PixelDefinition): Int
 }
 
 @ContributesBinding(AppScope::class)
@@ -68,6 +73,17 @@ class FreeTrialExperimentDataStoreImpl @Inject constructor(
         }
     }
 
+    override suspend fun increaseMetricForPixelDefinition(definition: PixelDefinition): Int =
+        withContext(dispatcherProvider.io()) {
+            val tag = "$definition"
+            val count = preferences.getInt(tag, 0)
+            preferences.edit {
+                putInt(tag, count + 1)
+                apply()
+            }
+            preferences.getInt(tag, 0)
+        }
+
     companion object {
         private const val FILENAME = "com.duckduckgo.subscriptions.freetrial.store"
         private const val KEY_PAYWALL_IMPRESSIONS = "PAYWALL_IMPRESSIONS"

diff --git a/...java/com/duckduckgo/subscriptions/impl/freetrial/FreeTrialPrivacyProMetricsPixelPlugin.kt b/...java/com/duckduckgo/subscriptions/impl/freetrial/FreeTrialPrivacyProMetricsPixelPlugin.kt
@@ -111,7 +111,10 @@ class FreeTrialPrivacyProPixelsPlugin @Inject constructor(
         metricsPixel?.let { metric ->
             metric.getPixelDefinitions().forEach { definition ->
                 if (definition.isInConversionWindow()) {
-                    freeTrialExperimentDataStore.getMetricForPixelDefinition(definition).takeIf { it < metric.value.toInt() }?.let {
+                    freeTrialExperimentDataStore.getMetricForPixelDefinition(definition).takeIf {
+                        it < freeTrialExperimentDataStore.paywallImpressions
+                    }?.let {
+                        freeTrialExperimentDataStore.increaseMetricForPixelDefinition(definition)
                         pixel.fire(definition.pixelName, definition.params)
                     }
                 }