Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Task/Issue URL: https://app.asana.com/0/0/1208220396571848/f ### Description Clean up of the FocusedView and the FavouritesView for use in both NTP and legacy NTP ### Steps to test this PR _Pixels_ - [x] Add a Favourite - [x] Open Focused View - [x] Long press on a favourite and tap on Edit - [x] Verify m_edit_favourite_dialog_shown sent - [x] Verify m_edit_favourite_dialog_shown_daily sent - [x] Navigate back - [x] Long press on a favourite and tap on Remote Favourite - [x] Wait for favourite to be removed (snackbar dissappear) - [x] Verify m_favorite_removed sent - [x] Add another favourite - [x] Long press on a favourite and tap on Delete - [x] Wait for favourite to be deleted (snackbar dissappear) - [x] Verify m_favorite_deleted sent - [x] Repeat same actions but this time from New Tab Page - [x] Verify pixels are still sent _Legacy NTP_ Use https://www.jsonblob.com/api/1280863591262445568 so you’re not part of the experiment Make sure you are not a reinstaller and using playDebug flavour - [x] Open New Tab - [x] Verify Dax Logo is visible - [x] Add a favourite and open New Tab again - [x] Verify favourites are visible - [x] Verify sections are not visible (this verifies you see the legacy NTP) - [x] Remove favourite (wait for the snackbar to disappear) - [x] Verify Dax Logo is visible _New NTP_ Use https://www.jsonblob.com/api/1270091613312245760 in Remote Config so you’re part of the experiment Make sure you are not a reinstaller and using playDebug flavour - [x] Open New Tab - [x] Verify Favourites placeholders and shortcuts are visible - [x] Add a favourite and open New Tab again - [x] Verify favourites are visible - [x] Remove favourite (wait for the snackbar to disappear) - [x] Verify Favourites placeholders and shortcuts are visible - [x] Verify Dax logo is not visible
- Loading branch information