Skip to content

Commit

Permalink
Request device authentication for sync account related actions (#4466)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/488551667048375/1206876054968714/f

### Description

### Steps to test this PR

_Sync disabled_
- [x] Without any device authentication
- [x] User should not be able to create/recover/join account
- [x] dialog should be displayed
- [x] button should take the user to settings

_Sync enabled_
- [x] Setup a device authentication
- [x] create account
- [x] Disable device authentication
- [x] User should not be able to add a new device / store recovery code
- [x] dialog should be displayed
- [x] button should take the user to settings

### UI changes
| Before  | After |
| ------ | ----- |
!(Upload before screenshot)|(Upload after screenshot)|

---------

Co-authored-by: root <[email protected]>
  • Loading branch information
cmonfortep and root authored May 5, 2024
1 parent 1f23ece commit 95467fe
Show file tree
Hide file tree
Showing 83 changed files with 626 additions and 46 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/sync-critical-path.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Assemble internal release APK
uses: gradle/gradle-build-action@v2
with:
arguments: assembleInternalRelease -Pforce-default-variant -x lint
arguments: assembleInternalRelease -Pforce-default-variant -Psync-disable-auth-requirement -x lint

- name: Move APK to new folder
if: always()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Удостоверете се, за да потвърдите, че искате да изтриете всички пароли</string>
<string name="autofill_title_text_for_delete_all">Изтриване на всички пароли</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Вашата парола за %1$s не може да се синхронизира, защото някои от нейните полета надвишават ограничението за знаци.</item>
<item quantity="other">Вашите пароли за %1$s и %2$d други сайта не могат да се синхронизират, защото някои от техните полета надвишават ограничението за знаци.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Управление на пароли</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,13 @@
<string name="autofill_auth_text_for_delete_all">Ověřením potvrď, že chceš smazat všechna hesla</string>
<string name="autofill_title_text_for_delete_all">Smazat všechna hesla</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Tvoje heslo pro %1$s se nedá synchronizovat, protože některé z jeho polí překračuje maximální počet znaků.</item>
<item quantity="few">Tvoje hesla pro %1$s a %2$d další weby se nedají synchronizovat, protože některá z jejich polí překračují maximální počet znaků.</item>
<item quantity="many">Tvoje hesla pro %1$s a %2$d dalšího webu se nedají synchronizovat, protože některá z jejich polí překračují maximální počet znaků.</item>
<item quantity="other">Tvoje hesla pro %1$s a %2$d dalších webů se nedají synchronizovat, protože některá z jejich polí překračují maximální počet znaků.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Spravovat hesla</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Bekræft, at du vil slette alle adgangskoder</string>
<string name="autofill_title_text_for_delete_all">Slet alle adgangskoder</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Din adgangskode til %1$s kan ikke synkroniseres, fordi nogle af dens felter overskrider tegngrænsen.</item>
<item quantity="other">Dine adgangskoder til %1$s og %2$d andre sider kan ikke synkroniseres, fordi nogle af deres felter overskrider tegngrænsen.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Administrer adgangskoder</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Authentifiziere dich, um zu bestätigen, dass du alle Passwörter löschen willst</string>
<string name="autofill_title_text_for_delete_all">Alle Passwörter löschen</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Dein Passwort für %1$s kann nicht synchronisiert werden, weil eines seiner Felder das Zeichenlimit überschreitet.</item>
<item quantity="other">Deine Passwörter für %1$s und %2$d andere Websites können nicht synchronisiert werden, weil einige ihrer Felder das Zeichenlimit überschreiten.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Passwörter verwalten</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Επαληθεύστε την ταυτότητά σας για να επιβεβαιώσετε ότι θέλετε να διαγράψετε όλους τους κωδικούς πρόσβασης</string>
<string name="autofill_title_text_for_delete_all">Διαγραφή όλων των κωδικών πρόσβασης</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Ο κωδικός πρόσβασής σας για τον %1$s δεν μπορεί να συγχρονιστεί επειδή ορισμένα από τα πεδία του υπερβαίνουν το όριο χαρακτήρων.</item>
<item quantity="other">Οι κωδικοί πρόσβασής σας για τον %1$s και %2$d ακόμα ιστότοπους δεν μπορούν να συγχρονιστούν επειδή ορισμένα από τα πεδία τους υπερβαίνουν το όριο χαρακτήρων.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Διαχείριση κωδικών πρόσβασης</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Autentícate para confirmar que deseas borrar todas las contraseñas</string>
<string name="autofill_title_text_for_delete_all">Borrar todas las contraseñas</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">La contraseñas de %1$s no se puede sincronizar porque algunos de sus campos superan el límite de caracteres.</item>
<item quantity="other">Las contraseñas de %1$s y %2$d otros sitios más no se pueden sincronizar porque algunos de sus campos superan el límite de caracteres.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Gestionar contraseñas</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Autendi end, et kinnitada kõigi paroolide kustutamine</string>
<string name="autofill_title_text_for_delete_all">Kustuta kõik paroolid</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Sinu parooli %1$s jaoks ei saa sünkroonida, sest üks selle väljadest ületab tähemärgipiirangu.</item>
<item quantity="other">Sinu paroolid %1$s ja %2$d muu saidi jaoks ei saa sünkroonida, kuna mõned nende väljad ületavad tähemärgipiirangu.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Halda paroole</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Vahvista, että haluat poistaa kaikki salasanat.</string>
<string name="autofill_title_text_for_delete_all">Poista kaikki salasanat</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Sivuston %1$s salasanoja ei voi synkronoida, koska jotkin niiden kentät ylittävät merkkirajoituksen.</item>
<item quantity="other">Sivuston %1$s ja %2$d muun salasanoja ei voi synkronoida, koska jotkin niiden kentät ylittävät merkkirajoituksen.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Hallitse salasanoja</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Authentifiez-vous pour confirmer que vous souhaitez supprimer tous les mots de passe</string>
<string name="autofill_title_text_for_delete_all">Supprimer tous les mots de passe</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Votre mot de passe pour %1$s ne peut pas être synchronisé car l\'un de ses champs dépasse la limite de caractères.</item>
<item quantity="other">Vos mots de passe pour %1$s et %2$d autres sites ne peuvent pas être synchronisés car certains de leurs champs dépassent la limite de caractères.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Gérer les mots de passe</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,13 @@
<string name="autofill_auth_text_for_delete_all">Izvrši autentifikaciju i time potvrdi da želiš izbrisati sve lozinke</string>
<string name="autofill_title_text_for_delete_all">Izbriši sve lozinke</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Tvoje lozinke za %1$s ne mogu se sinkronizirati jer neka njihova polja premašuju ograničenje broja znakova.</item>
<item quantity="few">Tvoje lozinke za %1$s i %2$d drugih web-mjesta ne mogu se sinkronizirati jer neka njihova polja premašuju ograničenje broja znakova.</item>
<item quantity="many">Tvoje lozinke za %1$s i %2$d drugih web-mjesta ne mogu se sinkronizirati jer neka njihova polja premašuju ograničenje broja znakova.</item>
<item quantity="other">Tvoje lozinke za %1$s i %2$d drugih web-mjesta ne mogu se sinkronizirati jer neka njihova polja premašuju ograničenje broja znakova.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Upravljanje lozinkama</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Hitelesítéssel erősítsd meg, hogy minden jelszót törölni szeretnél</string>
<string name="autofill_title_text_for_delete_all">Minden jelszó törlése</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">A(z) %1$s webhely jelszava nem szinkronizálható, mert egyik mezője meghaladja a karakterkorlátot.</item>
<item quantity="other">A(z) %1$s és %2$d másik webhely jelszavai nem szinkronizálhatók, mert egyes mezőik meghaladják a karakterkorlátot.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Jelszavak kezelése</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Esegui l\'autenticazione per confermare l\'eliminazione di tutte le password</string>
<string name="autofill_title_text_for_delete_all">Elimina tutte le password</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">La password per %1$s non può essere sincronizzata perché uno dei suoi campi supera il limite di caratteri.</item>
<item quantity="other">Le password per %1$s e altri %2$d siti non possono essere sincronizzate perché alcuni dei loro campi superano il limite di caratteri.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Gestisci password</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,13 @@
<string name="autofill_auth_text_for_delete_all">Patvirtinkite tapatybę, kad patvirtintumėte, jog norite ištrinti visus slaptažodžius</string>
<string name="autofill_title_text_for_delete_all">Ištrinti visus slaptažodžius</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Jūsų %1$s slaptažodžio negalima sinchronizuoti, nes tekstas, viename iš laukų, viršija simbolių limitą.</item>
<item quantity="few">Jūsų %1$s ir %2$d kitų svetainių slaptažodžių negalima sinchronizuoti, nes tekstas kai kuriuose laukuose viršija simbolių limitą.</item>
<item quantity="many">Jūsų %1$s ir %2$d kitų svetainės slaptažodžių negalima sinchronizuoti, nes tekstas kai kuriuose laukuose viršija simbolių limitą.</item>
<item quantity="other">Jūsų %1$s ir %2$d kitų svetainių slaptažodžių negalima sinchronizuoti, nes tekstas kai kuriuose laukuose viršija simbolių limitą.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Slaptažodžių valdymas</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,12 @@
<string name="autofill_auth_text_for_delete_all">Autentificējies, lai apstiprinātu, ka vēlies dzēst visas paroles</string>
<string name="autofill_title_text_for_delete_all">Dzēst visas paroles</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="zero">Tavas paroles vietnei %1$s un vēl %2$d vietnēm nevar sinhronizēt, jo daži to lauki pārsniedz rakstzīmju ierobežojumu.</item>
<item quantity="one">Tavu paroli vietnei %1$s nevar sinhronizēt, jo kāds no tās laukiem pārsniedz rakstzīmju ierobežojumu.</item>
<item quantity="other">Tavas paroles vietnei %1$s un vēl %2$d vietnēm nevar sinhronizēt, jo daži to lauki pārsniedz rakstzīmju ierobežojumu.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Pārvaldīt paroles</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Godkjenn for å bekrefte at du vil slette alle passord</string>
<string name="autofill_title_text_for_delete_all">Slett alle passord</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Passordet for %1$s kan ikke synkroniseres fordi ett av feltene overskrider tegngrensen.</item>
<item quantity="other">Passordene for %1$s og %2$d andre nettsteder kan ikke synkroniseres fordi noen av feltene overskrider tegngrensen.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Administrer passord</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Verifieer om te bevestigen dat je alle wachtwoorden wilt verwijderen</string>
<string name="autofill_title_text_for_delete_all">Alle wachtwoorden verwijderen</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Je wachtwoord voor %1$s kan niet worden gesynchroniseerd omdat sommige velden de tekenlimiet overschrijden.</item>
<item quantity="other">Je wachtwoorden voor %1$s en %2$d andere websites kunnen niet worden gesynchroniseerd omdat sommige velden de tekenlimiet overschrijden.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Wachtwoorden beheren</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,13 @@
<string name="autofill_auth_text_for_delete_all">Uwierzytelnij, aby potwierdzić, że chcesz usunąć wszystkie hasła</string>
<string name="autofill_title_text_for_delete_all">Usuń wszystkie hasła</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Nie można zsynchronizować hasła do %1$s, ponieważ jedno z jego pól przekracza limit znaków.</item>
<item quantity="few">Nie można zsynchronizować haseł do %1$s i %2$d innych witryn, ponieważ niektóre ich pola przekraczają limit znaków.</item>
<item quantity="many">Nie można zsynchronizować haseł do %1$s i %2$d innych witryn, ponieważ niektóre ich pola przekraczają limit znaków.</item>
<item quantity="other">Nie można zsynchronizować haseł do %1$s i %2$d innej witryny, ponieważ niektóre ich pola przekraczają limit znaków.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Zarządzaj hasłami</annotation></string>

</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,11 @@
<string name="autofill_auth_text_for_delete_all">Autentica para confirmar que pretendes eliminar todas as palavras-passe</string>
<string name="autofill_title_text_for_delete_all">Eliminar todas as palavras-passe</string>

<!-- Sync settings screen -->
<plurals name="syncCredentialInvalidItemsWarning" instruction="%1$ represents a site name or url, %2$d is the number of other invalid sites">
<item quantity="one">Não é possível sincronizar a tua palavra-passe para %1$s porque um dos campos excede o limite de carateres.</item>
<item quantity="other">Não é possível sincronizar as tuas palavras-passe para %1$s e mais %2$d sites porque alguns dos campos excedem o limite de carateres.</item>
</plurals>
<string name="syncCredentialInvalidItemsWarningLink"><annotation type="manage_passwords">Gerir palavra-passes</annotation></string>

</resources>
Loading

0 comments on commit 95467fe

Please sign in to comment.