Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update Settings: Address Ppro Issues (#5460)
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209138029097313/f Address Ship Review comments regarding not being able to see Ppro settings items when subscriptions expired. It was necessary to consider available Products ([you may see these referred to as "features" internally in the subscription module](https://app.asana.com/0/414730916066338/1209117572597478/f)) when a user's subscription has expired or they are in a waiting state, as their entitlements would end up being empty. Now we know what Products are available to the user, we can display them correctly in their disabled state to match the new Settings design. Prerequisite: `newSettings` feature flag is enabled Follow these [instructions](https://app.asana.com/0/1142021229838617/1208861246073828/f) to install Play Billing Lab so you can test US and ROW subscription plans **US** Prerequisite: Country/Region is set to US in Play Billing Lab _New Settings Top Level_ - [x] Open Settings screen - [x] Verify items displayed match design Not Subscribed state _Subscribed State_ - [ ] Tap "Get Privacy Pro" - [ ] Purchase Ppro monthly - [ ] One Purchase is completed return to top level settings screen - [ ] Verify VPN, PIR, ITR and Settings items are displayed, matching design Subscribed state - [ ] Turn on VPN - [ ] Return to top level settings screen - [ ] Ensure VPN status indicator is on - [ ] Turn VPN off - [ ] Return to top level settings screen - [ ] Ensure VPN status is off _Expired State_ - [ ] Tap "Subscription Settings" - [ ] Click "Update Plan or Cancel" item - [ ] Cancel the Subscription - [ ] Wait 5 mins - [ ] Return to top level settings screen - [ ] Verify VPN, PIR, ITR are in a disabled state like designs - [ ] Verify VPN, PIR, ITR are not clickable - [ ] Verify Settings item is in expired state _Remove subscription_ - [ ] Re-purchase Ppro - [ ] From the Subscription Settings screen click "Remove From this Device" - [ ] Return to top level settings screen - [ ] Verify you're in the Not Subscribed state _Activating State_ Prerequisite: Apply patch in [task](https://app.asana.com/0/1207908166761516/1209138029097313/f) as this is hard to reproduce via device - [ ] Apply patch - [ ] Open settings - [ ] Verify Ppro is in Activating state like designs - [ ] Verify VPN, PIR, ITR are not clickable - [ ] Re-purchase Ppro - [ ] From the Subscription Settings screen click "Remove From this Device" - [ ] Return to top level settings screen - [ ] Verify you're in the Not Subscribed state **ROW** Prerequisite: Country/Region is set to UK in Play Billing Lab _New Settings Top Level_ - [ ] Open Settings screen - [ ] Verify items displayed match design Not Subscribed state _Subscribed State_ - [ ] Tap "Get Privacy Pro" - [ ] Purchase Ppro monthly - [ ] One Purchase is completed return to top level settings screen - [ ] Verify only VPN, ITR and Settings items are displayed and match design Subscribed state - [ ] Turn on VPN - [ ] Return to top level settings screen - [ ] Ensure VPN status indicator is on - [ ] Turn VPN off - [ ] Return to top level settings screen - [ ] Ensure VPN status is off _Expired State_ - [ ] Tap "Subscription Settings" - [ ] Click "Update Plan or Cancel" item - [ ] Cancel the Subscription - [ ] Wait 5 mins - [ ] Return to top level settings screen - [ ] Verify only VPN, ITR are in a disabled state like designs - [ ] Verify VPN, ITR are not clickable - [ ] Verify Settings item is in expired state _Remove subscription_ - [ ] Re-purchase Ppro - [ ] From the Subscription Settings screen click "Remove From this Device" - [ ] Return to top level settings screen - [ ] Verify you're in the Not Subscribed state No UI changes but it's helpful to see the [designs](https://www.figma.com/design/CjH849hL53lhsPlf6Ufeo4/%E2%9A%99%EF%B8%8F-Browser-Settings-Documentation-(All-Platforms)?node-id=7605-431390&t=RdmuNULWUyR1cMH7-4) to remember our new states
- Loading branch information