-
Notifications
You must be signed in to change notification settings - Fork 950
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove params from user segment pixel (#4983)
Task/Issue URL: https://app.asana.com/0/488551667048375/1208217925635108/f ### Description Remove all default pixel params from user segment pixel. Incidentally I have also moved all statistics pixels from the `statistics-api` module to the `-impl` module, as there's no reason for them to be public API ### Steps to test this PR Just moving code around, there's no behavior change - [x] all tests shall pass
- Loading branch information
Showing
7 changed files
with
64 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...statistics-impl/src/main/java/com/duckduckgo/app/statistics/pixels/StatisticsPixelName.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| * Copyright (c) 2024 DuckDuckGo | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.duckduckgo.app.statistics.pixels | ||
|
|
||
| import androidx.annotation.VisibleForTesting | ||
| import androidx.annotation.VisibleForTesting.Companion.PACKAGE_PRIVATE | ||
| import com.duckduckgo.app.statistics.pixels.Pixel.PixelName | ||
|
|
||
| @VisibleForTesting(otherwise = PACKAGE_PRIVATE) | ||
| enum class StatisticsPixelName(override val pixelName: String) : PixelName { | ||
| BROWSER_DAILY_ACTIVE_FEATURE_STATE("m_browser_feature_daily_active_user_d"), | ||
| RETENTION_SEGMENTS("m_retention_segments"), | ||
| } |
35 changes: 35 additions & 0 deletions
35
.../src/main/java/com/duckduckgo/app/statistics/pixels/StatisticsPixelParamsRemovalPlugin.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Copyright (c) 2024 DuckDuckGo | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.duckduckgo.app.statistics.pixels | ||
|
|
||
| import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin | ||
| import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin.PixelParameter | ||
| import com.duckduckgo.di.scopes.AppScope | ||
| import com.squareup.anvil.annotations.ContributesMultibinding | ||
|
|
||
| @ContributesMultibinding( | ||
| scope = AppScope::class, | ||
| boundType = PixelParamRemovalPlugin::class, | ||
| ) | ||
| object StatisticsPixelParamsRemovalPlugin : PixelParamRemovalPlugin { | ||
| override fun names(): List<Pair<String, Set<PixelParameter>>> { | ||
| return listOf( | ||
| StatisticsPixelName.BROWSER_DAILY_ACTIVE_FEATURE_STATE.pixelName to PixelParameter.removeAll(), | ||
| StatisticsPixelName.RETENTION_SEGMENTS.pixelName to PixelParameter.removeAll(), | ||
| ) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters