Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android ANR: com.duckduckgo.app.tabs.ui.TabSwitcherAdapter.loadTabPreviewImage #5432

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Jan 3, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1209069285792730/f

Description

Moved file operations to background.

Steps to test this PR

  • Install from this branch.
  • Open many tabs and go to the Tab Switcher screen.
  • Notice the tabs are loaded properly and the app doesn't freeze.

NO UI changes

Copy link
Contributor Author

anikiki commented Jan 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@anikiki anikiki changed the title Moved file operations to background. Android ANR: com.duckduckgo.app.tabs.ui.TabSwitcherAdapter.loadTabPreviewImage Jan 3, 2025
@anikiki anikiki marked this pull request as ready for review January 3, 2025 14:34
@CDRussell CDRussell self-assigned this Jan 6, 2025
Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In addition to the testing steps, I always tried clearing the app cache and checking it handles that well; it does 👍

@anikiki anikiki merged commit ad28ee1 into develop Jan 6, 2025
8 checks passed
@anikiki anikiki deleted the fix/ana/android_anr_com_duckduckgo_app_tabs_ui_tabswitcheradapter_loadtabpreviewimage branch January 6, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants