Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Settings: Add new pixels #5434

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Jan 6, 2025

Task/Issue URL: https://app.asana.com/0/1207908166761516/1208880593716452/f

Description

Adds new pixels to Settings where we were missing some compared to iOS. See task for more details.

Steps to test this PR

Prerequisite: Enable newSettings feature toggle

Cookie Pop-Up Protection

  • Open Cookie Pop-Up Protection screen
  • Check m_settings_autoconsent_shown Pixel is fired
  • Toggle pop-up protection off
  • Check m_settings_autoconsent_off Pixel is fired
  • Toggle pop-up protection on
  • Check m_settings_autoconsent_on Pixel is fired

Next Steps: Address Bar Position

  • From main Settings screen click "Set Your Address Bar Position"
  • Check m_settings_next_steps_set_address_bar Pixel is fired

Next Steps: Enable Voice Search

  • Use a Pixel device
  • From main Settings screen click "Enable Voice Search"
  • Check m_settings_next_steps_enable_voice_search Pixel is fired

UI changes

N/A

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mikescamell mikescamell force-pushed the feature/mike/update-settings/update-pixels branch from e069ed3 to ebb77b3 Compare January 6, 2025 09:36
@mikescamell mikescamell marked this pull request as ready for review January 6, 2025 10:38
@mikescamell mikescamell force-pushed the feature/mike/update-settings/update-pixels branch from 5f0e4b9 to 81dda08 Compare January 6, 2025 12:03
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikescamell mikescamell merged commit 7a9ba7c into develop Jan 7, 2025
7 checks passed
@mikescamell mikescamell deleted the feature/mike/update-settings/update-pixels branch January 7, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants