Multi-selection: Add a new feature flag for multi-selection #5464
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
42e94eb to
0d73e35
Compare
11 tasks
0nko
changed the title
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
0b382b2 to
8492b52
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
8492b52 to
c4c3cf8
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
c3270a9 to
e6e2148
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
e6e2148 to
ff15dd9
Compare
This was referenced Feb 3, 2025
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
ff15dd9 to
02fb482
Compare
0nko
requested review from
mikescamell
and removed request for
malmstein and
nalcalag
mikescamell
reviewed
Feb 13, 2025
Comment on lines
39
to
36
| @ContributesMultibinding( | ||
| scope = AppScope::class, | ||
| boundType = ApiInterceptorPlugin::class, | ||
| ) | ||
| class BlockListInterceptorApiPlugin @Inject constructor( | ||
| class BlockListInterceptorApiPlugin constructor( |
There was a problem hiding this comment.
❓ Why was this removed?
There was a problem hiding this comment.
Hmm, seems like this was added with a rebase.
mikescamell
approved these changes
Feb 13, 2025
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
eab74f4 to
3d62cf6
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
3d62cf6 to
01126c4
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
01126c4 to
b38ddf4
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
cca1829 to
da3cae9
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
3 times, most recently
from
3536b27 to
4b5cef8
Compare
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209138029097313/f Address Ship Review comments regarding not being able to see Ppro settings items when subscriptions expired. It was necessary to consider available Products ([you may see these referred to as "features" internally in the subscription module](https://app.asana.com/0/414730916066338/1209117572597478/f)) when a user's subscription has expired or they are in a waiting state, as their entitlements would end up being empty. Now we know what Products are available to the user, we can display them correctly in their disabled state to match the new Settings design. Prerequisite: `newSettings` feature flag is enabled Follow these [instructions](https://app.asana.com/0/1142021229838617/1208861246073828/f) to install Play Billing Lab so you can test US and ROW subscription plans **US** Prerequisite: Country/Region is set to US in Play Billing Lab _New Settings Top Level_ - [x] Open Settings screen - [x] Verify items displayed match design Not Subscribed state _Subscribed State_ - [ ] Tap "Get Privacy Pro" - [ ] Purchase Ppro monthly - [ ] One Purchase is completed return to top level settings screen - [ ] Verify VPN, PIR, ITR and Settings items are displayed, matching design Subscribed state - [ ] Turn on VPN - [ ] Return to top level settings screen - [ ] Ensure VPN status indicator is on - [ ] Turn VPN off - [ ] Return to top level settings screen - [ ] Ensure VPN status is off _Expired State_ - [ ] Tap "Subscription Settings" - [ ] Click "Update Plan or Cancel" item - [ ] Cancel the Subscription - [ ] Wait 5 mins - [ ] Return to top level settings screen - [ ] Verify VPN, PIR, ITR are in a disabled state like designs - [ ] Verify VPN, PIR, ITR are not clickable - [ ] Verify Settings item is in expired state _Remove subscription_ - [ ] Re-purchase Ppro - [ ] From the Subscription Settings screen click "Remove From this Device" - [ ] Return to top level settings screen - [ ] Verify you're in the Not Subscribed state _Activating State_ Prerequisite: Apply patch in [task](https://app.asana.com/0/1207908166761516/1209138029097313/f) as this is hard to reproduce via device - [ ] Apply patch - [ ] Open settings - [ ] Verify Ppro is in Activating state like designs - [ ] Verify VPN, PIR, ITR are not clickable - [ ] Re-purchase Ppro - [ ] From the Subscription Settings screen click "Remove From this Device" - [ ] Return to top level settings screen - [ ] Verify you're in the Not Subscribed state **ROW** Prerequisite: Country/Region is set to UK in Play Billing Lab _New Settings Top Level_ - [ ] Open Settings screen - [ ] Verify items displayed match design Not Subscribed state _Subscribed State_ - [ ] Tap "Get Privacy Pro" - [ ] Purchase Ppro monthly - [ ] One Purchase is completed return to top level settings screen - [ ] Verify only VPN, ITR and Settings items are displayed and match design Subscribed state - [ ] Turn on VPN - [ ] Return to top level settings screen - [ ] Ensure VPN status indicator is on - [ ] Turn VPN off - [ ] Return to top level settings screen - [ ] Ensure VPN status is off _Expired State_ - [ ] Tap "Subscription Settings" - [ ] Click "Update Plan or Cancel" item - [ ] Cancel the Subscription - [ ] Wait 5 mins - [ ] Return to top level settings screen - [ ] Verify only VPN, ITR are in a disabled state like designs - [ ] Verify VPN, ITR are not clickable - [ ] Verify Settings item is in expired state _Remove subscription_ - [ ] Re-purchase Ppro - [ ] From the Subscription Settings screen click "Remove From this Device" - [ ] Return to top level settings screen - [ ] Verify you're in the Not Subscribed state No UI changes but it's helpful to see the [designs](https://www.figma.com/design/CjH849hL53lhsPlf6Ufeo4/%E2%9A%99%EF%B8%8F-Browser-Settings-Documentation-(All-Platforms)?node-id=7605-431390&t=RdmuNULWUyR1cMH7-4) to remember our new states
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
4b5cef8 to
32bdd14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207418217763355/1209148925370449/f
Description
This PR adds a feature flag for the tab multi-selection project.
Steps to test this PR
Nothing to test, this will serve as a feature branch.