Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary pixel when not showing trackers network dialog #5471

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jan 14, 2025

Task/Issue URL: https://app.asana.com/0/1205278999335242/1208163185498327/f

Description

Remove temporary pixel when skipping major network onboarding dialog when Duck Player dialog is shown

Steps to test this PR

Pixel removed

  • Fresh install
  • Go to any youtube URL
  • Check pixel m_onboarding_skip_major_network_unique is not sent and it works as expected

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review January 14, 2025 19:39
Copy link
Contributor

@CrisBarreiro CrisBarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected!

@nalcalag nalcalag merged commit 47a9f7f into develop Jan 15, 2025
8 checks passed
@nalcalag nalcalag deleted the feature/noelia/remove_temporary_pixel_skip_onboarding_duck_player branch January 15, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants